Re: [PATCH v2] git-gui: bring Wish process to front on Mac
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 14, 2013, 17:54 UTC
- Message-ID
- <7vwqpwo9wd.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1370642211-34416-1-git-send-email-stefan@haller-berlin.de>
Stefan Haller <stefan@haller-berlin.de> writes:
Show 9 quoted lines
> On Mac OS X, any application that is started from the Terminal will open > behind all running applications; as a work-around, manually bring ourselves > to the front. (Stolen from gitk, commit 76bf6ff93e.) > > We do this as the very first thing, so that any message boxes that might pop > up during the rest of the startup sequence are actually seen by the user. > > Signed-off-by: Stefan Haller <stefan@haller-berlin.de> > ---
Pat, is there any progress on this? I do not mind, and I actually would prefer, a pull request early in the development cycle.
"I've been busy and haven't got around to it", is a perfectly acceptable response. Just pinging to check.
Show 33 quoted lines
> Changes since the first patch:
> - add catch
> - specify full path to /usr/bin/osascript
>
> git-gui.sh | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index e133331..a792924 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -29,6 +29,21 @@ Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA}]
>
> ######################################################################
> ##
> +## On Mac, bring the current Wish process window to front
> +
> +if {[tk windowingsystem] eq "aqua"} {
> + catch {
> + exec /usr/bin/osascript -e [format {
> + tell application "System Events"
> + set frontmost of processes whose unix id is %d to true
> + end tell
> + } [pid] ]
> + }
> +}
> +
> +
> +######################################################################
> +##
> ## Tcl/Tk sanity check
>
> if {[catch {package require Tcl 8.4} err]