git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: bring Wish process to front on Mac

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 6, 2013, 18:15 UTC
Message-ID
<7vk3m7yukc.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CABNJ2G+h3zh+=wLA0KHjUn8TsfhqUK1Kn-1_=6hnXVRJUPhuuA@mail.gmail.com>
Pat Thoyts <patthoyts@gmail.com> writes:
Show 11 quoted lines
> Seems fine to me. I can't test this as I have no access to this
> platform. Possibly you should run this in a catch statement so it can
> ignore any errors and I would tend to use the 'auto_execok' command to
> ensure that osascript actually exists. Something like
>
>   set arg [format {tell application......}]
>   catch {exec {*}[auto_execok osascript] -e $arg [pid]}
>
> but possibly this is guaranteed to exist on all macs which would make
> the above redundant. What I'm thinking is you dont want the app to
> exit just because something goes wrong in this call.

Sounds like a sensible concern; gitk in v1.8.3 has it without catch so we may see failure reports from OSX users soonish, in which case both this patch and gitk need to be updated for it.

Stefan (as your name appears in 76bf6ff93e, I am assuming that you were the OSX-osascript guru in that commit) could you keep an eye on the list traffic to see if users of latest gitk have issues with that change, please?

Thanks.
Previous: Pat ThoytsNext: Stefan Haller
Message 7 of 8 in “git-gui: bring Wish process to front on Mac”
  1. git-gui: bring Wish process to front on MacStefan Haller, Jun 6, 2013
  2. Pat ThoytsJun 6, 2013
  3. Stefan HallerJun 6, 2013
  4. git-gui: bring Wish process to front on MacStefan Haller, Jun 7, 2013
  5. Junio C HamanoJun 14, 2013
  6. Pat ThoytsJun 15, 2013
  7. Junio C HamanoJun 6, 2013
  8. Stefan HallerJun 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.