git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Adjust diff-helper to diff-tree -v -z changes.

From
Junio C Hamano <junkio@cox.net>
Date
May 28, 2005, 04:05 UTC
Message-ID
<7vvf54xael.fsf_-_@assigned-by-dhcp.cox.net>
In-Reply-To
<7vfyw8zg1w.fsf@assigned-by-dhcp.cox.net>

The latest change to diff-tree -z output adds an extra line termination after non diff-raw material (the header and the commit message). To compensate for this change, stop adding the output termination of our own. "diff-tree -v -z" piped to "diff-helper -z" would give different result from "diff-tree -v" piped to "diff-helper" without this change.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff-helper.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/diff-helper.c b/diff-helper.c
--- a/diff-helper.c
+++ b/diff-helper.c
@@ -15,6 +15,7 @@ static const char *diff_helper_usage =
 
 int main(int ac, const char **av) {
 	struct strbuf sb;
+	const char *garbage_flush_format;
 
 	strbuf_init(&sb);
 
@@ -30,6 +31,8 @@ int main(int ac, const char **av) {
 			usage(diff_helper_usage);
 		ac--; av++;
 	}
+	garbage_flush_format = (line_termination == 0) ? "%s" : "%s\n";
+
 	/* the remaining parameters are paths patterns */
 
 	diff_setup(0);
@@ -134,7 +137,7 @@ int main(int ac, const char **av) {
 		if (pickaxe)
 			diffcore_pickaxe(pickaxe, pickaxe_opts);
 		diff_flush(DIFF_FORMAT_PATCH, 0);
-		printf("%s\n", sb.buf);
+		printf(garbage_flush_format, sb.buf);
 	}
 	if (1 < ac)
 		diffcore_pathspec(av + 1);
------------------------------------------------
Previous: Junio C HamanoNext: Linus Torvalds
Message 11 of 13 in “Fix ptrdiff_t vs. int”
  1. Fix ptrdiff_t vs. intMarkus F.X.J. Oberhumer, May 27, 2005
  2. Danjel McGouganMay 27, 2005
  3. Morten WelinderMay 27, 2005
  4. H. Peter AnvinMay 27, 2005
  5. Linus TorvaldsMay 27, 2005
  6. Linus TorvaldsMay 27, 2005
  7. Markus F.X.J. OberhumerMay 27, 2005
  8. H. Peter AnvinMay 27, 2005
  9. Linus TorvaldsMay 27, 2005
  10. Junio C HamanoMay 27, 2005
  11. Adjust diff-helper to diff-tree -v -z changes.Junio C Hamano, May 28, 2005
  12. Linus TorvaldsMay 29, 2005
  13. Junio C HamanoMay 29, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.