Re: [PATCH] Fix ptrdiff_t vs. int

From: H. Peter Anvin <hpa@zytor.com>
Date: May 27, 2005, 17:58 UTC
Message-ID: <42975FDD.9050901@zytor.com>
In-Reply-To: <42975C1F.8070102@oberhumer.com>

Markus F.X.J. Oberhumer wrote:

Show 5 quoted lines

> 
> Many thanks. BTW, this is probably completely irrelevant on all 
> real-world machines and calling conventions, but still, lying on the 
> number of arguments in vararg-functions is not my favourite practice.
>

Bullshit.

Think about the way stdarg works, and you should quickly figure out that it is perfectly safe to pass extra arguments.

However, this code can also be rewritten:

	fputs(header, stdout);
	if (diff_output_format == DIFF_FORMAT_MACHINE)
		putchar('\0');

... which is probably faster anyway.

	-hpa