git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] gitweb: Default to $hash_base or HEAD for $hash in "commit" and "commitdiff" views

From
Junio C Hamano <junkio@cox.net>
Date
Nov 8, 2006, 22:21 UTC
Message-ID
<7vvelpr34d.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<200611082311.35161.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 9 quoted lines
> Set $hash parameter to $hash_base || "HEAD" if it is not set (if it is
> not true to be more exact). This allows [hand-edited] URLs with 'action'
> "commit" or "commitdiff" but without 'hash' parameter.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> RFC because I want to ask if we should default to HEAD if hash is not
> provided for commit and commitdiff views, or should we error out with
> more reasonable error message.

Probably the latter; the user might be hand-crafting a URL (maybe learned a commit object name from mailing list and cutting and pasting) and mispasted the long hexadecimal string. Silently giving HEAD may leave the user confused than "oops, we do not see that commit object".

Previous: Jakub NarebskiNext: Jakub Narebski
Message 2 of 4 in “gitweb: Default to $hash_base or HEAD for $hash in "commit" and "commitdiff" views”
  1. gitweb: Default to $hash_base or HEAD for $hash in "commit" and "commitdiff" viewsJakub Narebski, Nov 8, 2006
  2. Junio C HamanoNov 8, 2006
  3. Jakub NarebskiNov 8, 2006
  4. Junio C HamanoNov 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.