Re: [PATCH/RFC] gitweb: Default to $hash_base or HEAD for $hash in "commit" and "commitdiff" views
- From
Junio C Hamano <junkio@cox.net>
- Date
- Nov 9, 2006, 00:09 UTC
- Message-ID
- <7vejsdqy4l.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200611082335.28296.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 13 quoted lines
>> Probably the latter; the user might be hand-crafting a URL >> (maybe learned a commit object name from mailing list and >> cutting and pasting) and mispasted the long hexadecimal string. >> Silently giving HEAD may leave the user confused than "oops, we >> do not see that commit object". > > No, if there is 'h' (hash) parameter provided, then gitweb tries > to use this. HEAD is used _only_ if nether hash, nor hash_base > are provided, i.e. for URL like below > > URL?p=project.git;a=commit > > i.e. without neither 'h' nor 'hb'.
Ah, that one I agree it makes sense to use HEAD. Also I am all for giving a more readable error message.