Re: I just pulled and built 'next'...
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jan 8, 2007, 20:11 UTC
- Message-ID
- <7vvejhwa6g.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <E1H3uc2-0004m1-Ua@think.thunk.org>
"Theodore Ts'o" <tytso@mit.edu> writes:
Show 8 quoted lines
> I just pulled and built 'next' and it reported a version number of > 1.4.4.4.g71bb6 -- and not one v1.5.0-rc0.g71bb6. I can understand why, > since it found the changes pulled in from the maint branch before it > found the v1.5.0-rc0 tag --- but it could be more than a little > misleading. Is this something that can be fixed in any way, short of > finding all of the tags reachable from HEAD and then doing a sort? That > seems like a gross kludge, but I can't think of any other way of fixing > it.
One question is how you would sort the result. If you sort them by taggerdate, you would get v1.4.4.4 anyway ;-).
If we go with topology, we do not necessarily have to find all the tags. When we hit a commit that is tagged, we can stop the traversal (so after finding v1.5.0-rc0, we do not have to go back along the 'master' lineage to find v1.4.4 tag). Traversing from the tip of 'master' (or 'next') this way we will notice that v1.5.0-rc0 and v1.4.4.4 are the candidates without going any further in the past.
But the question still remains which one between the two to pick.