Re: I just pulled and built 'next'...

From: Theodore Tso <tytso@mit.edu>
Date: Jan 8, 2007, 21:00 UTC
Message-ID: <20070108210002.GA15121@thunk.org>
In-Reply-To: <7vvejhwa6g.fsf@assigned-by-dhcp.cox.net>

On Mon, Jan 08, 2007 at 12:11:35PM -0800, Junio C Hamano wrote:

> One question is how you would sort the result.  If you sort them
> by taggerdate, you would get v1.4.4.4 anyway ;-).

I was assuming either lexigraphically, or via some really complicated rpm/dpkg version number comparison scheme. :-)

Show 10 quoted lines

> If we go with topology, we do not necessarily have to find all
> the tags.  When we hit a commit that is tagged, we can stop the
> traversal (so after finding v1.5.0-rc0, we do not have to go
> back along the 'master' lineage to find v1.4.4 tag).  Traversing
> from the tip of 'master' (or 'next') this way we will notice
> that v1.5.0-rc0 and v1.4.4.4 are the candidates without going
> any further in the past.
> 
> But the question still remains which one between the two to
> pick.

Yeah, that is the question. If we're willing to look at the tag name, it's pretty clear that if both v1.5.0-rc0 and v1.4.4.4 is reachable from the head, it should be based on the "newer" version, i.e., v1.5.0-rc0. A human can figure this out easily, but algorithimically we end up having to use something like the rpm or dpkg version comparison algorithm, both of which are hueristics that will sometimes get thigns wrong.

						- Ted