Re: [PATCH] Change to the repository's root directory if needed.

From: Junio C Hamano <junkio@cox.net>
Date: Jan 12, 2007, 23:17 UTC
Message-ID: <7vvejbq1gt.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <45A807A9.3090402@midwinter.com>

Steven Grimm <koreth@midwinter.com> writes:

Show 7 quoted lines

> Junio C Hamano wrote:
>> Porcelains that define SUBDIRECTORY_OK but do not do cdup are
>> very valid, and they should not be cd'ed up automatically.
>>
>
> My patch doesn't do the cd if SUBDIRECTORY_OK is defined, for exactly
> that reason.

Ah, I misread the patch.  Sorry.

But the point is that the scripts that do not currently say SUBDIRECTORY_OK have not even been audited to see if it makes sense to always cd to the top. Isn't your patch making as if they are saying SUBDIRECTORY_OK=Yes and cd to the top upfront is the right thing to do?