Re: [PATCH 3/3] Allow whole-tree operations to be started from a subdirectory

From: Andreas Ericsson <ae@op5.se>
Date: Jan 16, 2007, 15:14 UTC
Message-ID: <45ACEBE6.40506@op5.se>
In-Reply-To: <200701140111.20671.Josef.Weidendorfer@gmx.de>

Josef Weidendorfer wrote:

Show 20 quoted lines

> On Friday 12 January 2007 21:56, Junio C Hamano wrote:
>> This updates five commands (merge, pull, rebase, revert and cherry-pick)
>> so that they can be started from a subdirectory.
>>
>> This may not actually be what we want to do.  These commands are
>> inherently whole-tree operations, and an inexperienced user may
>> mistakenly expect a "git pull" from a subdirectory would merge
>> only the subdirectory the command started from.
> 
> Yes, this IMHO is a problem.
> 
> Why not add a general "--top" option to the "git" wrapper,
> to temporarily let git change to the toplevel while running
> the command?
> 
> The wish to allow git-fetch from subdirectories is the
> inconvenience to have to cd up, and later down. This is
> avoided by running "git --top fetch", and theses people
> should be happy.
>

It has the feel of forcing me to tell git to do the right thing when it's perfectly capable of figuring out what the right thing is on its own.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231