git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-bisect.sh: properly dq $GIT_DIR

From
Junio C Hamano <junkio@cox.net>
Date
Mar 23, 2007, 21:57 UTC
Message-ID
<7vvegroc78.fsf@assigned-by-dhcp.cox.net>
Otherwise you would be in trouble if your GIT_DIR has IFS letters in it.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 git-bisect.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 8eaea7c..936b4a4 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -141,7 +141,7 @@ bisect_next() {
 	bad=$(git-rev-parse --verify refs/bisect/bad) &&
 	good=$(git-rev-parse --sq --revs-only --not \
 		$(cd "$GIT_DIR" && ls refs/bisect/good-*)) &&
-	rev=$(eval "git-rev-list --bisect $good $bad -- $(cat $GIT_DIR/BISECT_NAMES)") || exit
+	rev=$(eval "git-rev-list --bisect $good $bad -- $(cat "$GIT_DIR/BISECT_NAMES")") || exit
 	if [ -z "$rev" ]; then
 	    echo "$bad was both good and bad"
 	    exit 1
-- 
1.5.1.rc1.651.g2ca06
Message 1 of 1 in “git-bisect.sh: properly dq $GIT_DIR”
  1. git-bisect.sh: properly dq $GIT_DIRJunio C Hamano, Mar 23, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.