threads / patch / 7374

patchgit-bisect.sh: properly dq $GIT_DIR

Subject: [PATCH] git-bisect.sh: properly dq $GIT_DIR

## tl;dr

One message between Mar 23, 2007 and Mar 23, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· Mar 23, 2007, 21:57 UTC · lore
Otherwise you would be in trouble if your GIT_DIR has IFS letters in it.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 git-bisect.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-bisect.sh +1 −1
diff --git a/git-bisect.sh b/git-bisect.sh
index 8eaea7c..936b4a4 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -141,7 +141,7 @@ bisect_next() {
 	bad=$(git-rev-parse --verify refs/bisect/bad) &&
 	good=$(git-rev-parse --sq --revs-only --not \
 		$(cd "$GIT_DIR" && ls refs/bisect/good-*)) &&
-	rev=$(eval "git-rev-list --bisect $good $bad -- $(cat $GIT_DIR/BISECT_NAMES)") || exit
+	rev=$(eval "git-rev-list --bisect $good $bad -- $(cat "$GIT_DIR/BISECT_NAMES")") || exit
 	if [ -z "$rev" ]; then
 	    echo "$bad was both good and bad"
 	    exit 1
-- 
1.5.1.rc1.651.g2ca06

← back to recent threads