git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix read-tree storing wrong tree reference with modified index

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 8, 2010, 23:42 UTC
Message-ID
<7vvd8po804.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20100708224653.GB50404@book.hvoigt.net>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 5 quoted lines
>  	 * The same holds true if we are switching between two trees
> -	 * using read-tree -m A B.  The index must match B after that.
> +	 * using read-tree A B (without -m). The index must match B
> +	 * after that. With given -m it can be a mix of the old index
> +	 * and the read one.

I think the justification of the original patch is completely bogus. Why not just drop the priming instead? Two-tree read-tree without -m does not make much sense but the result would look like an overlay of two trees, and is not likely to match either of the trees.

Previous: Heiko VoigtNext: Junio C Hamano
Message 2 of 4 in “fix read-tree storing wrong tree reference with modified index”
  1. fix read-tree storing wrong tree reference with modified indexHeiko Voigt, Jul 8, 2010
  2. Junio C HamanoJul 8, 2010
  3. Junio C HamanoJul 9, 2010
  4. Heiko VoigtJul 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.