From: Junio C Hamano Date: Thu, 08 Jul 2010 23:42:51 GMT Subject: Re: [PATCH] fix read-tree storing wrong tree reference with modified index Message-ID: <7vvd8po804.fsf@alter.siamese.dyndns.org> In-Reply-To: <20100708224653.GB50404@book.hvoigt.net> Heiko Voigt writes: > * The same holds true if we are switching between two trees > - * using read-tree -m A B. The index must match B after that. > + * using read-tree A B (without -m). The index must match B > + * after that. With given -m it can be a mix of the old index > + * and the read one. I think the justification of the original patch is completely bogus. Why not just drop the priming instead? Two-tree read-tree without -m does not make much sense but the result would look like an overlay of two trees, and is not likely to match either of the trees.