Re: [PATCH, RFC] Fix build problems related to profile-directed optimization

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 2, 2012, 20:02 UTC
Message-ID: <7vvcnpuhpo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1328209417-8206-1-git-send-email-tytso@mit.edu>

Theodore Ts'o <tytso@mit.edu> writes:

Show 12 quoted lines

> diff --git a/INSTALL b/INSTALL
> index 6fa83fe..978ed09 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -28,8 +28,8 @@ set up install paths (via config.mak.autogen), so you can write instead
>  If you're willing to trade off (much) longer build time for a later
>  faster git you can also do a profile feedback build with
>  
> -	$ make profile-all
> -	# make prefix=... install
> +	$ make prefix=... profile-all
> +	# make prefix=... PROFILE_USE=t install

Thanks for a patch. How does this compare with what was discussed in the other thread?

  http://thread.gmane.org/gmane.comp.version-control.git/188992/focus=189172

I would wish a solution ideally would support

	make PROFILE_BUILD=YesPlease
        make PROFILE_BUILD=YesPlease install

or even

	echo >>config.mak PROFILE_BUILD
        make
        su make install

and I think your patch takes us in the right direction.