Re: [PATCH, RFC] Fix build problems related to profile-directed optimization

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 3, 2012, 06:00 UTC
Message-ID: <7vr4ycsbga.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120203020743.GE1032@thunk.org>

Ted Ts'o <tytso@mit.edu> writes:

Show 7 quoted lines

> What do you think of this?  I'm still running a test build --- "make
> PROFILE=BUILD all" takes quite a long time, so this is still an RFC; I
> figure there will still be some places where people will point out
> more nits to be polished.  :-)
>
> (In particular, I just noticed I left the V=1 for debugging purposes
> in this version....)

Thanks.

Three comments:

 * I am happy that this version handles this well:

   $ make PROFILE=BUILD install

   even though you did not advertise as such in INSTALL ;-).

 * However, I think "clean" target should remove *.gcda unconditionally.

   $ make PROFILE=BUILD install ; make clean ; git clean -n -x | grep gcda

 * Running "make PROFILE=BUILD install" immediately after another one,
   without "make clean" in between, resulted in full rebuild and test
   before the second "install", which somewhat surprised me.  I however do
   not think this is a big show-stopper problem.