Re: [PATCH] tag: add --author option

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 27, 2012, 20:42 UTC
Message-ID: <7vvclphj2x.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F71F902.8090200@in.waw.pl>

Zbigniew Jędrzejewski-Szmek  <zbyszek@in.waw.pl> writes:

Show 11 quoted lines

>> +	if (force_author) {
>> +		const char *lb = strstr(force_author, "<");
>> +		const char *rb = strchr(force_author, '>');
>> +
>> +		if (!lb || !rb)
>> +			die(_("malformed --author parameter"));
>> +			name = xstrndup(force_author, lb - force_author);
>> +			email = xstrndup(lb + 2, rb - (lb + 2));
>
> This part is identical to builtin/commit.c, it would be nice to
> refactor it into a function.

Or we may want to use something like split_ident_line() from 4b340cf (ident.c: add split_ident_line() to parse formatted ident line, 2012-03-11) to consolidate the parsing of this kind of stuff even further.