Re: [PATCH] tag: add --author option

From: Mathias Weber <mweb@gmx.ch>
Date: Mar 27, 2012, 21:11 UTC
Message-ID: <4F722D18.50502@gmx.ch>
In-Reply-To: <7vr4wdhilj.fsf@alter.siamese.dyndns.org>

On 27.03.2012 22:52, Junio C Hamano wrote:

Show 23 quoted lines

> Mathias Weber <mweb@gmx.ch> writes:
> 
>> On 27.03.2012 19:29, Zbigniew Jędrzejewski-Szmek wrote:
>>> On 03/27/2012 06:00 PM, Mathias Weber wrote:
>>>>
>>>> The tag command does not support the --author option as the
>>>> commit command. This adds the --author option to create
>>>> annotated tags with a different author.
>>>
>>> Consistency is good.
>>
>> It would be good but during the rework of the patch I realized that for
>> the tag the committer is and should be used and not the author.
>> Therefore it is fine that this option isn't available. I'm sorry
>> bothering you.
> 
> I would have thought that being able to lie about "tagger " would be
> equivalent to lying about --author of the commit.  What am I missing?
> 
> Not that I am enthused by the idea of having to add another option.  I
> would be perfectly happy if we did not add such a flag.  It is just I do
> not understand the reasoning behind the retraction.
>

Yes this was what I first though as well but isn't the tagger similar to the committer? With the --author option we change only the author of a commit and not the committer. To change the committer you have to provide the env variable GIT_COMMITTER_NAME and GIT_COMMITER_EMAIL or change the config file. I haven't found a option to change the committer. I think the tagger is about the same as the committer. It make sens to have a committer and an author for a commit and this might not even be the same person but for a tag there is only the tagger. Which is the person how makes the tag.

Mathias