Re: [PATCH v2 4/5] index-pack, unpack-objects: add --not-so-strict for connectivity check

From: Junio C Hamano <gitster@pobox.com>
Date: May 1, 2013, 23:35 UTC
Message-ID: <7vvc722s0h.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1367405974-22190-5-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 6 quoted lines

> --not-so-strict only checks if all links from objects in the pack
> point to real objects (either in current repo, or from the pack
> itself). It's like check_everything_connected() except that:
>
>  - it does not follow DAG in order
>  - it can detect incomplete object islands

Could you clarify what this second point means?

"rev-list --objects --all --not $this $that" does not detect "islands" but checking with the updated index-pack does?

>  - it seems to be faster than "rev-list --objects --all"

More important is that it makes sure that it is safe to update our refs to the new value, just like the check this attempts to replace. If that is not the case, the speed does not matter.

I am guessing that the code assumes that we are updating our refs to objects that are in the pack that we are looking at, and I can see how the new check in sha1_object() may detect an object that points at another object that is missing. But that assumption (which I think is correct) is probably the most important thing to say in the log message.

> +--not-so-strict::

Perhaps "--check-connectivity" is a better name than this?