Re: [PATCH 0/4] check_everything_connected replacement
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 1, 2013, 14:48 UTC
- Message-ID
- <7va9pil31m.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1364728148-7537-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> The last use of check_everything_connected after this series is > fetch.c:quickfetch(), which I think is unnecessary. It can only catch > errors if we have incomplete object islands in repo, which could > happen before this series.
A typical source of object islands the quickfetch() was designed to protect against is the HTTP walker. I do not think your patch adds any safety in that area (nor it should).
> After this series, incomplete object > islands can't enter the repository, at least via git transport.
Exactly.