Re: [PATCH] status: display the SHA1 of the commit being currently processed

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 17, 2013, 16:33 UTC
Message-ID: <7vvc5cg0i8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <51BF26F9.1080900@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 19 quoted lines

> Am 6/17/2013 15:57, schrieb Mathieu Liénard--Mayor:
>> Le 2013-06-17 15:54, Peter Krefting a écrit :
>>> Mathieu Liénard--Mayor:
>>>
>>>> Actually, at first I dealt with it this way:
>>>>
>>>> status_printf_ln(s, color,
>>>>                 _("Splitting %s while rebasing branch '%s' on '%s'."),
>>>>          stopped_sha ? stopped_sha : _("a commit"),
>>>>          ....);
>>>>
>>>> Would this be more suitable for translators ?
>>>
>>> Not really, the text surrounding "a commit" might need to be
>>> inflected differently depending on whether it is a SHA-1 or the "a
>>> commit" string. Word order might also be different.
>> Okay, I'll use what you suggested then.
>
> That's not a good idea. Do we already use "%1$" style formats elsewhere?

In the template, we obviously don't.

But my understanding is that the reordering using printf() is the mechanism we suggest l10n folks to use when the order of parameters given to printf does not match the preferred word order in the message in their language.