git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] status: display the SHA1 of the commit being currently processed

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 18, 2013, 16:32 UTC
Message-ID
<7v61xb752k.fsf@alter.siamese.dyndns.org>
In-Reply-To
<2dc2004fbf61d625515c2b6f62cc104e@ensibm.imag.fr>
Mathieu Liénard--Mayor <mathieu.lienard--mayor@ensimag.fr> writes:
Show 8 quoted lines
> Le 2013-06-17 20:37, Junio C Hamano a écrit :
> ...
>> Extend wt_status_state structure to hold the necessary info, query
>> the state from the filesystem in that function, and display the info
>> (but not collect info) in show_rebase_in_progress(), to keep the
>> clean division of labor between these two places.
>
> Do you mean that we should include the stopped_SHA in wt_status_state ?

That would be a good first step. In the longer term, we would want other external interfaces that read from wt-status-state, pick bits necessary and summarize them for particular use cases. You can for example easily imagine the prompt support that collects different pieces of breadcrumbs from .git/ can instead ask wt-status-state for necessary pieces information.

Separating the logic to collect state information and the code to show the result of collection is necessary for that kind of usage.

Previous: Mathieu Liénard--Mayor
Message 16 of 16 in “status: display the SHA1 of the commit being currently processed”
  1. status: display the SHA1 of the commit being currently processedMathieu Lienard--Mayor, Jun 17, 2013
  2. Thomas AdamJun 17, 2013
  3. Peter KreftingJun 17, 2013
  4. Mathieu Liénard--MayorJun 17, 2013
  5. Peter KreftingJun 17, 2013
  6. Mathieu Liénard--MayorJun 17, 2013
  7. Johannes SixtJun 17, 2013
  8. Junio C HamanoJun 17, 2013
  9. Peter KreftingJun 20, 2013
  10. Johannes SixtJun 20, 2013
  11. Junio C HamanoJun 20, 2013
  12. Johannes SixtJun 21, 2013
  13. Junio C HamanoJun 21, 2013
  14. Junio C HamanoJun 17, 2013
  15. Mathieu Liénard--MayorJun 18, 2013
  16. Junio C HamanoJun 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.