Re: [PATCH] Small optimizations to gitweb

From: Junio C Hamano <junkio@cox.net>
Date: Dec 19, 2006, 05:48 UTC
Message-ID: <7vtzzstozi.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200612190159.24173.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 6 quoted lines

> Junio C Hamano wrote:
>> ...
>> The counting code in git_*_body is seriously unusual to tempt
>> anybody who reviews the code to reduce that 17 to 16.
>
> Well, this should be then corrected perhaps to

Well, I did not say it was _wrong_, just unusual, so there is nothing to fix.

Show 6 quoted lines

>> By the way, I wonder how that $extra is omitted when $revlist is
>> longer than $to; it should be a trivial fix but it seems to me
>> that it is always spitted out with the current code.
>
> We should check if we want to omit $extra, either in caller or
> in callee, the *_body subroutine itself.

Check?