Re: [PATCH] gitweb: Show '...' links in "summary" view only if there are more items

From: Junio C Hamano <junkio@cox.net>
Date: Dec 19, 2006, 18:05 UTC
Message-ID: <7vr6uvpxqc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200612191328.08928.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 19 quoted lines

> Robert Fitzsimons wrote:
>> Show "..." links in "summary" view to shortlog, heads (if there are
>> any), and tags (if there are any) only if there are more items to show
>> than shown already.
>> 
>> This means that "..." link is shown below shortened shortlog if there
>> are more than 16 commits, "..." link below shortened heads list if
>> there are more than 16 heads refs (16 branches), "..." link below
>> shortened tags list if there are more than 16 tags.
>> 
>> Modified patch from Jakub to to apply cleanly to master, also preform
>> the same "..." link logic to the forks list.
>
> Junio usually puts such comments in brackets (I don't know if it is
> always used, i.e. if it is some 'convention'), e.g.:
>
>   Also perform the same "..." link logic to the forks list.
>
>   [rf: Modified patch from Jakub to to apply cleanly to master]

I would actually discourage this on messages that are still on the list (i.e. not in commits). I do [jc:] comment when I take the proposed commit log message from the incoming e-mail verbatim but I made modification to the patch text, because otherwise the original submitter cannot tell from the log message if that is meant to be identical to what was submitted.

I've only took a cursory look of the actual patch text, but what Robert sent looked good to me. Thanks, both.