Re: "git stash" is not known to git

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 30, 2007, 17:52 UTC
Message-ID: <7vtzrlkccp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070730100408.GA8829@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> On a related note, is it just me, or is the following comment and related code
> in git.c (introduced by Linus in 231af832) totally bogus:
>
>   /*
>    * We search for git commands in the following order:
>    *  - git_exec_path()
>    *  - the path of the "git" command if we could find it
>    *    in $0
>    *  - the regular PATH.
>    */
>
> We never actually look in the regular PATH since we call execv_git_cmd
> (although we do still munge the PATH, apparently so shell scripts can
> use git-foo syntax; see 77cb17e9). This means you can't drop "git-foo"
> into your PATH and have it work as "git foo".
>
> What is the desired behavior?

I failed to spot patches to the area without updating the comment. What the code does is fine, the comment is stale.