Re: "git stash" is not known to git

From: Jeff King <peff@peff.net>
Date: Jul 30, 2007, 10:04 UTC
Message-ID: <20070730100408.GA8829@coredump.intra.peff.net>
In-Reply-To: <vpqwswi2pkw.fsf@bauges.imag.fr>

On Mon, Jul 30, 2007 at 11:44:31AM +0200, Matthieu Moy wrote:

Show 5 quoted lines

> > One has to use git-stash rather than "git stash".  Oversight?
> 
> This looks like an incorrect installation, with git-stash in your
> $PATH, but not in the place git looks for its commands (I don't
> remember the exact mechanism).

On a related note, is it just me, or is the following comment and related code in git.c (introduced by Linus in 231af832) totally bogus:

  /*
   * We search for git commands in the following order:
   *  - git_exec_path()
   *  - the path of the "git" command if we could find it
   *    in $0
   *  - the regular PATH.
   */

We never actually look in the regular PATH since we call execv_git_cmd (although we do still munge the PATH, apparently so shell scripts can use git-foo syntax; see 77cb17e9). This means you can't drop "git-foo" into your PATH and have it work as "git foo".

What is the desired behavior?

-Peff