Re: [PATCH 2/3] archive: specfile support (--pretty=format: in archive files)

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 3, 2007, 23:53 UTC
Message-ID: <7vtzqb8fw2.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <46DC4D45.4030208@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

Show 6 quoted lines

> The attribute is useful for creating auto-updating specfiles.  It is
> limited by the underlying function format_commit_message(), though.
> E.g. currently there is no placeholder for git-describe like output,
> and expanded specfiles can't contain NUL bytes.  That can be fixed
> in format_commit_message() later and will then benefit users of
> git-log, too.

Interesting. I however wonder if "specfile" is a good name for this attribute, although I admit I do not think of anything better offhand.

Show 5 quoted lines

> Why did it take me that long to come up with such a simple patch?
> There was a vacation and a feature freeze in between, but above all
> I was only recently able to convince myself (using ugly code) that
> format_commit_message() can indeed be made to expand placeholders
> to git-describe strings..

Thanks.  Will take a look.