git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Must not modify the_index.cache as it may be passed to realloc at some point.

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 3, 2007, 05:55 UTC
Message-ID
<7vtzp8g2s2.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1191390255.16292.2.camel@koto.keithp.com>
Keith Packard <keithp@keithp.com> writes:
> The index cache is not static, growing as new entries are added. If entries
> are added after prune_cache is called, cache will no longer point at the
> base of the allocation, and realloc will not be happy.

Thanks for catching this. This code originally was perfectly Ok, but I broke it with the overlay_tree() change.

Previous: Keith PackardNext: Carl Worth
Message 2 of 14 in “Must not modify the_index.cache as it may be passed to realloc at some point.”
  1. Must not modify the_index.cache as it may be passed to realloc at some point.Keith Packard, Oct 3, 2007
  2. Junio C HamanoOct 3, 2007
  3. Add test case for ls-files --with-headCarl Worth, Oct 3, 2007
  4. Johannes SixtOct 3, 2007
  5. Johannes SchindelinOct 3, 2007
  6. David KastrupOct 3, 2007
  7. Carl WorthOct 3, 2007
  8. David KastrupOct 3, 2007
  9. Jeff KingOct 3, 2007
  10. Johannes SchindelinOct 3, 2007
  11. Junio C HamanoOct 3, 2007
  12. Jeff KingOct 3, 2007
  13. Junio C HamanoOct 3, 2007
  14. Add test case for ls-files --with-headCarl Worth, Oct 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.