git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-fast-export: Remove double spaces in author line

From
Junio C Hamano <gitster@pobox.com>
Date
May 30, 2008, 20:27 UTC
Message-ID
<7vtzgfk05i.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1212143475-48255-1-git-send-email-pdebie@ai.rug.nl>
Pieter de Bie <pdebie@ai.rug.nl> writes:
Show 11 quoted lines
> It produces 
>
> 	"author Samba Release Account <samba-bugs@samba.org>  831196245 +0000"
>
> The git-fast-import syntax says there can only be a single space after the >
> sign. This Samba commit breaks bzr-fast-import, for example.
>
> I'm not sure how to properly fix the problem, as I'm not very deep into Git's
> code. I included this patch in case anyone else has the same problem and wants
> a quick fix. I'm also not sure if it's a fast-export problem, or if the Samba
> repository is just invalid :)

You can call that repository broken if you want, but we can try to be liberal when receiving and be strict when generating. IOW, fast-import could accept such a minor deviation and generate a commit after fixing it. The same thing can be said about fast-export --- read, fix and generate.

By the way, your quick hack would however squash multiple SPs anywhere on the line, wouldn't it, not just the one between '>' and the timestamp?

Previous: Pieter de Bie
Message 2 of 2 in “builtin-fast-export: Remove double spaces in author line”
  1. builtin-fast-export: Remove double spaces in author linePieter de Bie, May 30, 2008
  2. Junio C HamanoMay 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.