From: Junio C Hamano Date: Fri, 30 May 2008 20:27:37 GMT Subject: Re: [PATCH] builtin-fast-export: Remove double spaces in author line Message-ID: <7vtzgfk05i.fsf@gitster.siamese.dyndns.org> In-Reply-To: <1212143475-48255-1-git-send-email-pdebie@ai.rug.nl> Pieter de Bie writes: > It produces > > "author Samba Release Account 831196245 +0000" > > The git-fast-import syntax says there can only be a single space after the > > sign. This Samba commit breaks bzr-fast-import, for example. > > I'm not sure how to properly fix the problem, as I'm not very deep into Git's > code. I included this patch in case anyone else has the same problem and wants > a quick fix. I'm also not sure if it's a fast-export problem, or if the Samba > repository is just invalid :) You can call that repository broken if you want, but we can try to be liberal when receiving and be strict when generating. IOW, fast-import could accept such a minor deviation and generate a commit after fixing it. The same thing can be said about fast-export --- read, fix and generate. By the way, your quick hack would however squash multiple SPs anywhere on the line, wouldn't it, not just the one between '>' and the timestamp?