Re: What's cooking in git.git (Aug 2008, #07; Sat, 23)

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2008, 20:19 UTC
Message-ID: <7vtzd8g851.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080825163203.GD22184@cuci.nl>

"Stephen R. van den Berg" <srb@cuci.nl> writes:

Show 15 quoted lines

> Junio C Hamano wrote:
> ...
>>It seems that kill_some_child() will not kill anything if nobody else is
>>coming from the same address, while the old code did kill some.  Is this
>>intended?
>
> This is intended.
> ...
>>...  If you
>>simplify add_child() to queue the newborn always at the front of the list,
>>your kill_some_child() will continue to do so, so I do not see the point
>>of the loop in add_child().  Am I mistaken?
> ...
> You are mistaken.
> The point is that we need to find out *duplicate* IP-adresses.

Lightbulb goes on on both counts.  Thanks.

> Shall I incorporate your suggested changes (as far as I consider them ok)
> into my patches and resubmit them?

I think your response makes the only remaining is the style fixup, which was my [1/3] from yesterday, so I think we are Ok with what already we have.

Thanks.