git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Aug 2008, #07; Sat, 23)

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 24, 2008, 19:16 UTC
Message-ID
<7vd4jymdfn.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0808241955550.24820@pacific.mpi-cbg.de.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 12 quoted lines
>> * sb/daemon (Thu Aug 14 20:02:20 2008 +0200) 4 commits
>>  - git-daemon: rewrite kindergarden, new option --max-connections
>>  - git-daemon: Simplify dead-children reaping logic
>>  - git-daemon: use LOG_PID, simplify logging code
>>  - git-daemon: call logerror() instead of error()
>> 
>> Can somebody who actually runs the daemon standalone comment on this 
>> one?
>
> I am somewhat uneasy about running my production machine with these 
> changes, since the last commit (the one introducing a kindergarden with 
> cradles) is too unobvious for me.
Well, I didn't ask anybody to _run_ it.

I asked people who care about their daemons to comment on the change, so that if there are any issues in the code that I didn't see, the breakage gets caught before it propagates to their daemons they build from 'next' or 'master'.

Having said that, I do agree that the kindergarden change is very involved (it removes more code than it adds --- the reduction of lines is somewhat inflated because quite a lot of comments that have become stale gets removed by the patch).

Previous: Johannes SchindelinNext: Junio C Hamano
Message 4 of 11 in “What's cooking in git.git (Aug 2008, #07; Sat, 23)”
  1. Junio C HamanoAug 24, 2008
  2. Maintaining "needswork" section of "What's (not) cooking"Junio C Hamano, Aug 24, 2008
  3. Johannes SchindelinAug 24, 2008
  4. Junio C HamanoAug 24, 2008
  5. Junio C HamanoAug 24, 2008
  6. 1/3 daemon.c: minor style fixupJunio C Hamano, Aug 24, 2008
  7. 2/3 daemon.c: simplify add_child() and kill_some_child() logicJunio C Hamano, Aug 24, 2008
  8. 3/3 daemon.c: make sure kill_some_child() really kills somebodyJunio C Hamano, Aug 24, 2008
  9. Stephen R. van den BergAug 25, 2008
  10. Junio C HamanoAug 25, 2008
  11. Stephen R. van den BergAug 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.