Re: [PATCH 3/3] git abbref-ref: new porcelain for abbreviate_ref()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 22, 2008, 15:55 UTC
- Message-ID
- <7vtzc8xjiv.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080922153222.GD3669@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 15 quoted lines
> Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>> This gives direct access to the abbreviate_ref() function. The operation
>> mode defaults to the core.warnambiguousrefs value, like the refname:short
>> format, but can be explicitly changed with the --{,no}-strict option.
>>
>> The bash completion script utilizes this new command.
>
> And it slows down too, doesn't it? Now we are doing a fork per
> branch during completion. Yikes. Didn't you just post a series
> about making completion faster?
>
>> Junio, if this is not a porcelain, tell me.
>
> IMHO its plumbing. Porcelain is used by a human. Plumbing is the
> bits needed to make human interfaces.Shawn is right.
I wouldn't be taking this patch to add a new command, but I suspect that this could be an option to rev-parse that is similar to --symbolic.
Teach SHOW_SYMBOLIC_SHORTEST to builtin-rev-parse.c::show_rev(), teach the parser cmd_rev_parse() a new option --symbolic-abbrev and you are done, right?
By the way, I found it amusing to see Cc: lines _after_ three dashes to control send-email --- nice trick I didn't think of ;-)