Re: [PATCH 1/3] for-each-ref: utilize core.warnambiguousrefs for strict refname:short format
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 22, 2008, 16:27 UTC
- Message-ID
- <7vk5d4xi1m.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1222074591-26548-1-git-send-email-bert.wesarg@googlemail.com>
Bert Wesarg <bert.wesarg@googlemail.com> writes:
Show 13 quoted lines
> diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c
> index 9b44092..e7b7712 100644
> --- a/builtin-for-each-ref.c
> +++ b/builtin-for-each-ref.c
> @@ -571,7 +571,7 @@ static void gen_scanf_fmt(char *scanf_fmt, const char *rule)
> /*
> * Shorten the refname to an non-ambiguous form
> */
> -static char *get_short_ref(struct refinfo *ref)
> +static void get_short_ref(struct refinfo *ref, int strict, char **short_ref)
> {
> int i;
> static char **scanf_fmts;As far as I can tell this changing of function signature does not help its existing caller nor the function's implementation.
Why? And especially why do this in a patch that does something else?