git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFCv3 1/2] gitweb: add patch view

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 6, 2008, 01:26 UTC
Message-ID
<7vtz9iw0uv.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200812060209.42906.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
> But we have also 'snapshot' feature, which like 'patches' is not simply
> on/off but is configurable feature, like 'patches' adds new action and
> does modify existing actions only by adding extra links... and which is
> enabled by default.

If my "git log" is telling the true story, "snapshot" was introduced in cb9c6e5 (gitweb: Support for snapshot, 2006-08-17) and it was disabled by default.

The "feature" mechanism was introduced after that, with ddb8d90 (gitweb: Make blame and snapshot a feature., 2006-08-20). To avoid surprises, "blame" were marked disabled by default to match the then-current default. "snapshot" somehow ended up enabled with that change, though, which might have been a mistake.

But "we erred before" is not a good excuse to deliberately err again, is it?

Previous: Jakub NarebskiNext: Giuseppe Bilotta
Message 15 of 20 in “[RFCv3 0/2] gitweb: patch view”
  1. Giuseppe BilottaDec 3, 2008
  2. 1/2 gitweb: add patch viewGiuseppe Bilotta, Dec 3, 2008
  3. 2/2 gitweb: links to patch action in commitdiff and shortlog viewGiuseppe Bilotta, Dec 3, 2008
  4. Jakub NarebskiDec 6, 2008
  5. Giuseppe BilottaDec 6, 2008
  6. Jakub NarebskiDec 6, 2008
  7. Junio C HamanoDec 3, 2008
  8. Giuseppe BilottaDec 4, 2008
  9. Junio C HamanoDec 4, 2008
  10. Jakub NarebskiDec 4, 2008
  11. Giuseppe BilottaDec 4, 2008
  12. Jakub NarebskiDec 6, 2008
  13. Junio C HamanoDec 6, 2008
  14. Jakub NarebskiDec 6, 2008
  15. Junio C HamanoDec 6, 2008
  16. Giuseppe BilottaDec 6, 2008
  17. Petr BaudisDec 6, 2008
  18. Giuseppe BilottaDec 6, 2008
  19. Jakub NarebskiDec 6, 2008
  20. Giuseppe BilottaDec 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.