From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 06 Dec 2008 01:26:00 GMT
Subject: Re: [RFCv3 1/2] gitweb: add patch view
Message-ID: <7vtz9iw0uv.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200812060209.42906.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> But we have also 'snapshot' feature, which like 'patches' is not simply
> on/off but is configurable feature, like 'patches' adds new action and
> does modify existing actions only by adding extra links... and which is
> enabled by default.

If my "git log" is telling the true story, "snapshot" was introduced in
cb9c6e5 (gitweb: Support for snapshot, 2006-08-17) and it was disabled by
default.

The "feature" mechanism was introduced after that, with ddb8d90 (gitweb:
Make blame and snapshot a feature., 2006-08-20).  To avoid surprises,
"blame" were marked disabled by default to match the then-current default.
"snapshot" somehow ended up enabled with that change, though, which might
have been a mistake.

But "we erred before" is not a good excuse to deliberately err again, is
it?