git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3/RFC 4/5] gitweb: Create links leading to 'blame_incremental' using JavaScript

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 12, 2009, 08:05 UTC
Message-ID
<7vtyx0f9rd.fsf@alter.siamese.dyndns.org>
In-Reply-To
<200911061905.52285.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
> But even if incremental blame turns out to be slower than incremental
> blame it still has the advantage of being _incremental_.  You have at 
> least some result soon.

It wasn't it was slow that bothered me, but early implementations of incremental blame I tried didn't _appear_ as incremental. That was the dissapointing part.

At the protocol and implementation level it certainly was feeding data incrementally to the browser, but the end user experience on the screen was "click....wait...wait...wait...voila the whole blame appears", not "click...trickle...trickle...trickle...ah everything is filled". The latter obviously is what an incremental one should be aiming for.

No I haven't tried your latest code.  Probably I should.
Previous: Jakub NarebskiNext: Jakub Narebski
Message 9 of 12 in “gitweb: Incremental blame series (1 Sep 09)”
  1. 0/5 gitweb: Incremental blame series (1 Sep 09)Jakub Narebski, Sep 1, 2009
  2. 1/5 gitweb: Add optional "time to generate page" info in footerJakub Narebski, Sep 1, 2009
  3. 2/5 gitweb: Incremental blame (using JavaScript)Jakub Narebski, Sep 1, 2009
  4. 3/5 gitweb: Colorize 'blame_incremental' view during processingJakub Narebski, Sep 1, 2009
  5. 4/5 gitweb: Create links leading to 'blame_incremental' using JavaScriptJakub Narebski, Sep 1, 2009
  6. 5/5 gitweb: Minify gitweb.js if JSMIN is definedJakub Narebski, Sep 1, 2009
  7. Petr BaudisNov 5, 2009
  8. Jakub NarebskiNov 6, 2009
  9. Junio C HamanoNov 12, 2009
  10. Jakub NarebskiNov 12, 2009
  11. Petr BaudisNov 5, 2009
  12. Jakub NarebskiNov 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.