git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] am: fix patch format detection for Thunderbird "Save As" emails

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 18, 2009, 00:15 UTC
Message-ID
<7vtyvpcf36.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1261094299-22930-1-git-send-email-bebarino@gmail.com>
Stephen Boyd <bebarino@gmail.com> writes:
> I'm not sure how portable \r in a sed invocation is.
Not very portable.
Adding
	tr -d '\015' <"$1" |
in front of the original "sed" invocation might be a better choice.
> but seems necessary because check_patch_format() is called before any
> splitting with mailsplit is done (where I assume the fix for the issue
> will be done).

I agree that the way non-native mbox format was bolted onto "am" is somewhat unfortunate.

Previous: Stephen BoydNext: Stephen Boyd
Message 2 of 16 in “am: fix patch format detection for Thunderbird "Save As" emails”
  1. am: fix patch format detection for Thunderbird "Save As" emailsStephen Boyd, Dec 17, 2009
  2. Junio C HamanoDec 18, 2009
  3. [PATCHv2] am: fix patch format detection for Thunderbird "Save As" emailsStephen Boyd, Dec 18, 2009
  4. Eric BlakeDec 18, 2009
  5. Stephen BoydDec 18, 2009
  6. Eric BlakeDec 18, 2009
  7. Stephen BoydDec 19, 2009
  8. Eric BlakeDec 19, 2009
  9. Stephen BoydDec 19, 2009
  10. Stephen BoydDec 19, 2009
  11. Junio C HamanoDec 19, 2009
  12. Stephen BoydDec 19, 2009
  13. Andreas SchwabDec 19, 2009
  14. Junio C HamanoDec 18, 2009
  15. Nanako ShiraishiJan 5, 2010
  16. Stephen BoydJan 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.