Re: [PATCHv2] am: fix patch format detection for Thunderbird "Save As" emails

From: Stephen Boyd <bebarino@gmail.com>
Date: Dec 19, 2009, 06:21 UTC
Message-ID: <4B2C70ED.1020602@gmail.com>
In-Reply-To: <4B2C66D3.1070508@byu.net>

On 12/18/2009 09:38 PM, Eric Blake wrote:

Show 8 quoted lines

> Closer, but not there yet.  "$/" is still not defined.  Then, as a matter
> of style, '\' is more readable than "\\" for representing a backslash.  So
> as long as we are shifting to '', we might as well do it everywhere in
> that line - write it like this:
>
> } | sed -e 's/$/;/' | tr ';' '\015'>  patch1-crlf.eml
>
> and you should be set.

Ah, I think you missed that this stuff is inside single quotes already. I would love to just do what you suggest here.

I'm a little confused because I see this in a test (am --committer-date-is-author-date) a ways down in the same file

     git cat-file commit HEAD | sed -e "/^$/q">head1&&

and following your reasoning that wouldn't be portable?

Either way, I'll look for a better replacement character instead of semi-colon.