git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] stash: Allow git stash branch to process commits that look like stashes but are not stash references.

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 5, 2010, 20:13 UTC
Message-ID
<7vtyn8ddhv.fsf@alter.siamese.dyndns.org>
In-Reply-To
<AANLkTi=FbF3X83uLjBDoCYUCuig3udTzZCXuE=1_w-Ld@mail.gmail.com>
Jon Seymour <jon.seymour@gmail.com> writes:
Show 6 quoted lines
> One question about test patches. Are you ok with test_expect_failure
> tests that document the expected failure of a feature yet to be
> developed, followed by the feature, followed by the patch that makes
> the tests into test_expect_success tests, or would you prefer to see
> the pre- and post- test patches rolled into a single test that is
> delivered after the feature patch?

I think a single patch that implements the feature and at the same time protects it with new tests from getting broken by others would be the best form.

Previous: Jon SeymourNext: Jon Seymour
Message 8 of 9 in “*** SUBJECT HERE ***”
  1. 0/3 *** SUBJECT HERE ***Jon Seymour, Aug 3, 2010
  2. 1/3 stash: It looks like a stash, but doesn't quack like a stash...Jon Seymour, Aug 3, 2010
  3. Junio C HamanoAug 4, 2010
  4. 2/3 stash: Allow git stash branch to process commits that look like stashes but are not stash references.Jon Seymour, Aug 3, 2010
  5. Junio C HamanoAug 4, 2010
  6. Jon SeymourAug 5, 2010
  7. Jon SeymourAug 5, 2010
  8. Junio C HamanoAug 5, 2010
  9. 3/3 stash: modify tests to reflect stash branch fixes.Jon Seymour, Aug 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.