From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 05 Aug 2010 20:13:32 GMT
Subject: Re: [PATCH v2 2/3] stash: Allow git stash branch to process commits that look like stashes but are not stash references.
Message-ID: <7vtyn8ddhv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTi=FbF3X83uLjBDoCYUCuig3udTzZCXuE=1_w-Ld@mail.gmail.com>

Jon Seymour <jon.seymour@gmail.com> writes:

> One question about test patches. Are you ok with test_expect_failure
> tests that document the expected failure of a feature yet to be
> developed, followed by the feature, followed by the patch that makes
> the tests into test_expect_success tests, or would you prefer to see
> the pre- and post- test patches rolled into a single test that is
> delivered after the feature patch?

I think a single patch that implements the feature and at the same time
protects it with new tests from getting broken by others would be the best
form.