Re: [PATCH] compat: add a getpass() compatibility function
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 20, 2011, 17:18 UTC
- Message-ID
- <7vtycp2sva.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <BANLkTikRCXLJfOJFZ7j0TV_rxsySgQwSsw@mail.gmail.com>
Erik Faye-Lund <kusmabite@gmail.com> writes:
> Actually, I'm thinking that we should avoid ever using getpass:
Good thinking.
> Instead, > we should make our own function (based on your most recent patch?) > that fills a caller-specified strbuf instead (git_getpass already have > a static strbuf that we can fill).
Heh, I thought you earlier felt "a bit pointless" to "a properly abstracted common version" I outlined earlier in the thread ;-)