From: Junio C Hamano Date: Fri, 20 May 2011 17:18:17 GMT Subject: Re: [PATCH] compat: add a getpass() compatibility function Message-ID: <7vtycp2sva.fsf@alter.siamese.dyndns.org> In-Reply-To: Erik Faye-Lund writes: > Actually, I'm thinking that we should avoid ever using getpass: Good thinking. > Instead, > we should make our own function (based on your most recent patch?) > that fills a caller-specified strbuf instead (git_getpass already have > a static strbuf that we can fill). Heh, I thought you earlier felt "a bit pointless" to "a properly abstracted common version" I outlined earlier in the thread ;-)