git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Improve legibility of test_expect_code output

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 20, 2012, 16:50 UTC
Message-ID
<7vtxusbpub.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAOkDyE-x5NeZX2tpp3C9Kkwb1kPniHptB9ERvtpx2XODufaW=A@mail.gmail.com>
Adam Spiers <git@adamspiers.org> writes:
Show 16 quoted lines
> On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Adam Spiers <git@adamspiers.org> writes:
>>
>>> ---
>>
>> No explanation why this is a good idea, nor sign-off?
>
> I realised I forgot the sign-off seconds after sending :-(
>
> Isn't it completely self-explanatory? e.g.
>
>     test_expect_code: command exited with 0, we wanted 128 git foo bar
>
> clearly makes more sense than
>
>     test_expect_code: command exited with 0, we wanted 128 from: git foo bar
test_expect_code: command exited with 0, we wanted 128: git foo bar
would be shorter and equally legible, I would think.

In any case, the proposed commit log message should have explained these differences in the first place so that I or others do not have to ask.

Do you want this queued on top of your other series, or as an independent change?

Previous: Adam SpiersNext: Adam Spiers
Message 6 of 9 in “Improve legibility of test_expect_code output”
  1. Improve legibility of test_expect_code outputAdam Spiers, Sep 19, 2012
  2. Junio C HamanoSep 20, 2012
  3. Adam SpiersSep 20, 2012
  4. Junio C HamanoSep 20, 2012
  5. Adam SpiersSep 20, 2012
  6. Junio C HamanoSep 20, 2012
  7. Adam SpiersSep 20, 2012
  8. Junio C HamanoSep 20, 2012
  9. Adam SpiersSep 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.