From: Junio C Hamano Date: Thu, 20 Sep 2012 16:50:52 GMT Subject: Re: [PATCH] Improve legibility of test_expect_code output Message-ID: <7vtxusbpub.fsf@alter.siamese.dyndns.org> In-Reply-To: Adam Spiers writes: > On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano wrote: >> Adam Spiers writes: >> >>> --- >> >> No explanation why this is a good idea, nor sign-off? > > I realised I forgot the sign-off seconds after sending :-( > > Isn't it completely self-explanatory? e.g. > > test_expect_code: command exited with 0, we wanted 128 git foo bar > > clearly makes more sense than > > test_expect_code: command exited with 0, we wanted 128 from: git foo bar test_expect_code: command exited with 0, we wanted 128: git foo bar would be shorter and equally legible, I would think. In any case, the proposed commit log message should have explained these differences in the first place so that I or others do not have to ask. Do you want this queued on top of your other series, or as an independent change?