git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] receive-pack: send pack-processing stderr over sideband

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 21, 2012, 17:25 UTC
Message-ID
<7vtxur70fv.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120921170539.GA19707@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> On Fri, Sep 21, 2012 at 09:49:40AM -0700, Junio C Hamano wrote:
>
>> >   2. No matter what the cause, we are probably better off
>> >      showing the errors to the client. If the client and the
>> >      server admin are not the same entity, it is probably
>> >      much easier for the client to cut-and-paste the errors
>> >      they see than for the admin to try to dig them out of a
>> >      log and correlate them with a particular session.
>> 
>> I agree with the "probably" above (and also with points 1 and 3),
>> but it at the same time feel a bit iffy.  The server side would lose
>> log entries to check when the operator observes higher error rate
>> and starts suspecting something recently broke, and the lost clue
>> cannot be recovered without contacting the pushers, no?
>
> Yeah, that is true, although that is already the case with ssh pushes.
> Conversely, it also means that servers using the ssh transport have lost
> the option of redirecting the server-side stderr (e.g., with a wrapper
> around git-receive-pack) to a log if they were already doing so.
Yes.
Show 6 quoted lines
> However, this does make things more consistent with upload-pack, which
> connects the stderr of pack-objects to sideband (which it must to handle
> progress). Furthermore, many of the messages from receive-pack are
> handled by rp_error, which sends to the sideband. So if you were
> monitoring your git purely by trying to capture stderr, you were already
> only getting a fraction of the real data.

The comments were not meant as a rejection notice ;-) Just to see if some server operators have input on the matter.

I personally do not think tee-ing the error output is worth it; it would be reasonably simple to arrange, and the server operators who want it can ask later if that is need.

Thanks.
Previous: Jeff KingNext: Jeff King
Message 6 of 8 in “nicer receive-pack errors over http”
  1. 0/3 nicer receive-pack errors over httpJeff King, Sep 21, 2012
  2. 1/3 receive-pack: redirect unpack-objects stdout to /dev/nullJeff King, Sep 21, 2012
  3. 2/3 receive-pack: send pack-processing stderr over sidebandJeff King, Sep 21, 2012
  4. Junio C HamanoSep 21, 2012
  5. Jeff KingSep 21, 2012
  6. Junio C HamanoSep 21, 2012
  7. Jeff KingSep 21, 2012
  8. 3/3 receive-pack: drop "n/a" on unpacker errorsJeff King, Sep 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.