git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] receive-pack: send pack-processing stderr over sideband

From
Jeff King <peff@peff.net>
Date
Sep 21, 2012, 17:40 UTC
Message-ID
<20120921174000.GA20896@sigill.intra.peff.net>
In-Reply-To
<7vtxur70fv.fsf@alter.siamese.dyndns.org>
On Fri, Sep 21, 2012 at 10:25:24AM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> > However, this does make things more consistent with upload-pack, which
> > connects the stderr of pack-objects to sideband (which it must to handle
> > progress). Furthermore, many of the messages from receive-pack are
> > handled by rp_error, which sends to the sideband. So if you were
> > monitoring your git purely by trying to capture stderr, you were already
> > only getting a fraction of the real data.
> 
> The comments were not meant as a rejection notice ;-) Just to see if
> some server operators have input on the matter.

I know. But your comment made me second-guess a little whether anybody would be inadvertently hurt, but thinking it through and writing it out helped convince myself that it's the right thing to do.

One of the hardest parts of working on a mature software project is not just thinking about what you want to do, but thinking about what everyone else wants to do (or is doing). So it never hurts to double-check your assumptions in such a case, and I don't mind working through these "what ifs" even if they end in us doing the original thing. I hope you do not mind reading them too much. :)

> I personally do not think tee-ing the error output is worth it; it
> would be reasonably simple to arrange, and the server operators who
> want it can ask later if that is need.
Agreed.
-Peff
Previous: Junio C HamanoNext: Jeff King
Message 7 of 8 in “nicer receive-pack errors over http”
  1. 0/3 nicer receive-pack errors over httpJeff King, Sep 21, 2012
  2. 1/3 receive-pack: redirect unpack-objects stdout to /dev/nullJeff King, Sep 21, 2012
  3. 2/3 receive-pack: send pack-processing stderr over sidebandJeff King, Sep 21, 2012
  4. Junio C HamanoSep 21, 2012
  5. Jeff KingSep 21, 2012
  6. Junio C HamanoSep 21, 2012
  7. Jeff KingSep 21, 2012
  8. 3/3 receive-pack: drop "n/a" on unpacker errorsJeff King, Sep 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.