Re: [PATCH 5/6] log: pass rev_info to git_log_config()

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 5, 2012, 19:07 UTC
Message-ID: <7vtxu8u48g.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20121005153341.GA24957@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Agreed. Maybe the simplest thing would be to have grep_config fill in a
> "static struct grep_opt grep_defaults", and then memcpy that into place
> during init_revisions?

Yes, I was doing that for a bit last night, but then realized that the grep_config() should be split into two (grep specific part and then the bits that cascade to others, which is "git grep" specific requirement; it is far better to let other callers to arrange the cascading themselves) before moving the grep specific bit to the top-level, so that needs to come first.