Re: grep.patternType

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 3, 2012, 22:14 UTC
Message-ID: <7vmx032of1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v626r48cv.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 23 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>>  * "git grep" learned to use a non-standard pattern type by default if
>>    a configuration variable tells it to.
>
> This addition makes
>
>     git grep -e "(integer|buffer)"
>
> work as expected, when grep.patternType is set to "extended".
>
> Should this
>
>     git log --grep="(integer|buffer)"
>
> also honor the same configuration variable?  If not, why not?
>
> One more thing.  Currently you can say
>
>     git log -E --grep="(integer|buffer)"
>
> to ask for the ERE.  Should we also support -P to ask for pcre?  If
> not, why not?

Answering to myself who has been in tying-loose-ends mode.

My answers to these questions are both yes, and I have a neatly lined up series that begins with a small bugfix and then enhancement, but I do not think these do not deserve to in the upcoming release. The topic came too late, and even the fix is for a bug that has been with us for a long time.