Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2013, 19:52 UTC
Message-ID: <7vtxjzk13q.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130712190531.GD8482@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

> FWIW the GIT_SSL_CERT_PASSWORD_PROTECTED envvar has a similar "can
> only enable" behavior, but since it's documented, that's not as big
> of a problem.  Do you remember why it was written that way?

Not me ;-).

If I have to guess, it is probably that these two are thought to be equally trivial way to defeat existing environment settings:

	(unset GIT_SSL_CERT_PASSWORD_PROTECTED ; git cmd)
        GIT_SSL_CERT_PASSWORD_PROTECTED=no git cmd

> When that setting was first added[1], there was some mention of
> autodetection if libcurl could learn to do that.  Did it happen?

I do not think so, but let's see if our resident cURL guru has something to say about it.